NO-ISSUE: test/extended/util/framework: Poll in IsMicroShiftCluster #30161
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
openshift-ci
bot
added
the
approved
|
/verified by examining all serial presubmits, no failures identified for these tests |
openshift-ci-robot
added
the
verified
|
@wking: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
2 similar comments
|
/retest-required |
1 similar comment
wking
force-pushed
the
harden-IsMicroShiftCluster
branch
from
d63d774 to
18c8314
Compare
openshift-ci-robot
removed
the
verified
|
Job Failure Risk Analysis for sha: 18c8314
|
wking
force-pushed
the
harden-IsMicroShiftCluster
branch
from
18c8314 to
3170441
Compare
The ConfigMap retrieval occasionally fails: $ curl -s 'https://search.dptools.openshift.org/search?maxAge=24h&type=junit&context=0&search=error%20accessing%20microshift-version%20configmap' | jq -r 'to_entries[] | .key as $k | .value | to_entries[].value[].context[] | $k + "\n " + .' https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-techpreview/1959742094134218752 I0824 23:53:47.495715 90800 framework.go:2294] error accessing microshift-version configmap: Get "https://api.ci-op-hfy5sixp-82aa7.origin-ci-int-aws.dev.rhcloud.com:6443/api/v1/namespaces/kube-public/configmaps/microshift-version": dial tcp: lookup api.ci-op-hfy5sixp-82aa7.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: read udp 10.129.136.246:33085->172.30.0.10:53: i/o timeout https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-cgroupsv2/1959742058285502464 I0824 23:53:34.234531 68956 framework.go:2294] error accessing microshift-version configmap: Get "https://api.ci-op-950shpk8-29422.XXXXXXXXXXXXXXXXXXXXXX:6443/api/v1/namespaces/kube-public/configmaps/microshift-version": dial tcp: lookup api.ci-op-950shpk8-29422.XXXXXXXXXXXXXXXXXXXXXX on 172.30.0.10:53: read udp 10.130.176.97:35168->172.30.0.10:53: i/o timeout https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.14-to-4.15-to-4.16-to-4.17-ci/1959761685916946432 I0825 04:30:25.015456 907 framework.go:2294] error accessing microshift-version configmap: Get "https://api.ci-op-wwl4bdif-d25a9.origin-ci-int-aws.dev.rhcloud.com:6443/api/v1/namespaces/kube-public/configmaps/microshift-version": dial tcp: lookup api.ci-op-wwl4bdif-d25a9.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: no such host https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30067/pull-ci-openshift-origin-main-e2e-hypershift-conformance/1959846453614481408 I0825 07:00:44.838632 72570 framework.go:2320] error accessing microshift-version configmap: Get "https://add640066b4a046d58cb9cc48def1e09-925574a45e949171.elb.us-east-1.amazonaws.com:6443/api/v1/namespaces/kube-public/configmaps/microshift-version": dial tcp: lookup add640066b4a046d58cb9cc48def1e09-925574a45e949171.elb.us-east-1.amazonaws.com on 172.30.0.10:53: read udp 172.24.238.50:43260->172.30.0.10:53: i/o timeout Placing it within a poll loop will avoid failing test-cases while they try to decide if the cluster is MicroShift or not, which is likely to be part of setup (e.g. "skip this test-case if the cluster is MicroShift"), and not the fundamental thing the test-case is trying to exercise. Ideally there would be no hard-coded duration, and IsMicroShiftCluster would take a Context argument set up with whatever the caller felt was a reasonable time to make that determination. But I didn't want to get into adjusting all the IsMicroShiftCluster callers, so for now, I'm just hard-coding the duration. In the kapierrs.IsNotFound(err) branch, I set 'cm' to nil. I do not understand why Get returns a zero-value &ConfigMap in the not-found case, but it does. When I inserted logging in this branch, the output was [1]: I0910 23:13:46.463728 119748 framework.go:2322] microshift-version not found, but ConfigMap is non nil? configmaps "microshift-version" not found &ConfigMap{ObjectMeta:{ 0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []},Data:map[string]string{},BinaryData:map[string][]byte{},Immutable:nil,} With the logic setting 'cm' to nil in that case, it keeps the later 'microshift-version configmap not found' return working. [1]: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30161/pull-ci-openshift-origin-main-e2e-aws-ovn-fips/1965881831995740160
|
/verified by examining all failing serial and MicroShift presubmits, no failures identified for these tests |
openshift-ci-robot
added
the
verified
|
@wking: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, sosiouxme, stbenjam, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Job Failure Risk Analysis for sha: 3170441
|
1 similar comment
openshift-merge-bot
bot
merged commit 821a738
into
openshift:main
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The ConfigMap retrieval occasionally fails:
Placing it within a poll loop will avoid failing test-cases while they try to decide if the cluster is MicroShift or not, which is likely to be part of setup (e.g. "skip this test-case if the cluster is MicroShift"), and not the fundamental thing the test-case is trying to exercise.
Ideally there would be no hard-coded duration, and
IsMicroShiftClusterwould take aContextargument set up with whatever the caller felt was a reasonable time to make that determination. But I didn't want to get into adjusting all theIsMicroShiftClustercallers, so for now, I'm just hard-coding the duration.